nastra commented on code in PR #7447:
URL: https://github.com/apache/iceberg/pull/7447#discussion_r1254708505
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -170,8 +189,35 @@ public String description() {
table(), branch(), Spark3Util.describe(filterExpressions),
groupingKeyFieldNamesAsString);
}
+ @Override
+ public CustomTaskMetric[] reportDriverMetrics() {
+ ScanReport scanReport = metricsReportSupplier != null ?
metricsReportSupplier.get() : null;
+ if (scanReport == null) {
Review Comment:
doesn't this behavior here contract with
```
public ScanReport scanReport() {
Preconditions.checkArgument(
metricsReport instanceof ScanReport, "Metric report is not a scan
report");
return (ScanReport) metricsReport;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
