Fokko commented on code in PR #7997: URL: https://github.com/apache/iceberg/pull/7997#discussion_r1254049187
########## python/pyiceberg/io/__init__.py: ########## @@ -50,6 +50,10 @@ S3_SECRET_ACCESS_KEY = "s3.secret-access-key" S3_SESSION_TOKEN = "s3.session-token" S3_REGION = "s3.region" +HDFS_HOST = "hdfs.host" +HDFS_PORT = "hdfs.port" +HDFS_USER = "hdfs.user" +HDFS_KERB_TICKET = "hdfs.kerb_ticket" Review Comment: For the PyIceberg configuration, we don't have to adhere to the PyArrow arguments. Because we have this flexibility, I would suggest extending `kerb` to `kerberos.` ```suggestion HDFS_KERB_TICKET = "hdfs.kerberos_ticket" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
