RussellSpitzer commented on code in PR #7900:
URL: https://github.com/apache/iceberg/pull/7900#discussion_r1248303763
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -666,6 +667,34 @@ public static Dataset<Row> loadMetadataTable(
spark, DataSourceV2Relation.create(metadataTable, Some.empty(),
Some.empty(), options));
}
+ public static String wapBranch(SparkSession spark, String branch) {
Review Comment:
I'm not sure it's clear enough from this name what this method is doing, can
we add a java doc or possibly a new name?
Looks like it returns the WAP Branch if it is configured in the Spark conf
and then the string that is passed in otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
