jackye1995 commented on code in PR #7880:
URL: https://github.com/apache/iceberg/pull/7880#discussion_r1248295325
##########
api/src/main/java/org/apache/iceberg/view/ViewBuilder.java:
##########
@@ -111,6 +111,16 @@ public interface ViewBuilder {
*/
ViewBuilder withProperty(String key, String value);
+ /**
+ * Add a view representation
+ *
+ * @param representation The view representation to add
+ * @return this for method chaining
+ */
+ default ViewBuilder withRepresentation(ViewRepresentation representation) {
Review Comment:
I think `ViewBuilder` is a class that we added a long long time ago without
much concrete knowledge about how we are going to do other things, so I am good
with deprecating all those methods. I am thinking if we could simplify it
further, can we do something like `ViewBuilder extends ImmutableView.Builder`?
##########
api/src/main/java/org/apache/iceberg/view/ViewBuilder.java:
##########
@@ -111,6 +111,16 @@ public interface ViewBuilder {
*/
ViewBuilder withProperty(String key, String value);
+ /**
+ * Add a view representation
+ *
+ * @param representation The view representation to add
+ * @return this for method chaining
+ */
+ default ViewBuilder withRepresentation(ViewRepresentation representation) {
Review Comment:
I think `ViewBuilder` is a class that we added a long long time ago without
much concrete knowledge about how we are going to do other things, so I am good
with deprecating all those methods. I am thinking if we could simplify it
further, can we do something like `BaseViewBuilder extends
ImmutableView.Builder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
