ConeyLiu commented on code in PR #7898:
URL: https://github.com/apache/iceberg/pull/7898#discussion_r1247503853
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -245,6 +251,22 @@ public static Expression convert(Predicate predicate) {
return null;
}
+ private static <T> Pair<UnboundTerm<T>, T> predicateChildren(Predicate
predicate) {
Review Comment:
@szehon-ho It should be OK to remove the `<T>` and use `Object` instead. And
also updated `handleEqual` and `handleNotEqual`.
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -282,18 +304,35 @@ private static boolean
isLiteral(org.apache.spark.sql.connector.expressions.Expr
return expr instanceof Literal;
}
- private static Object convertLiteral(Literal<?> literal) {
+ @SuppressWarnings("unchecked")
+ private static <T> T convertLiteral(Literal<?> literal) {
Review Comment:
updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
