nastra commented on code in PR #7895:
URL: https://github.com/apache/iceberg/pull/7895#discussion_r1241802681
##########
core/src/test/java/org/apache/iceberg/util/TestTableScanUtil.java:
##########
@@ -125,8 +123,7 @@ public void testTaskGroupPlanning() {
CloseableIterable<ScanTaskGroup<ParentTask>> taskGroups =
TableScanUtil.planTaskGroups(CloseableIterable.withNoopClose(tasks),
128, 10, 4);
-
- Assert.assertEquals("Must have 3 task groups", 3,
Iterables.size(taskGroups));
+ Assertions.assertThat(taskGroups).as("Must have 3 task groups").hasSize(3);
Review Comment:
why `Assertions.assertThat` here when you're using `assertThat` in all the
other places in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
