nastra commented on code in PR #7895:
URL: https://github.com/apache/iceberg/pull/7895#discussion_r1241782716
##########
core/src/test/java/org/apache/iceberg/util/TestInMemoryLockManager.java:
##########
@@ -28,29 +30,26 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.assertj.core.api.Assertions;
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.Timeout;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
public class TestInMemoryLockManager {
private LockManagers.InMemoryLockManager lockManager;
private String lockEntityId;
private String ownerId;
- @Rule public Timeout timeout = new Timeout(5, TimeUnit.SECONDS);
-
- @Before
+ @Timeout(value = 5, unit = TimeUnit.SECONDS)
Review Comment:
should this be moved to the class level to be globally applied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
