rdblue commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1240437589
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -57,6 +72,7 @@ public class SparkV2Filters {
private static final String FALSE = "ALWAYS_FALSE";
private static final String EQ = "=";
private static final String EQ_NULL_SAFE = "<=>";
+ private static final String NOT_EQ = "<>";
Review Comment:
I think that this was carried over from `SparkFilters`. I seem to remember
not having a `NotEq` filter defined at the time so Spark would always use
`Not(Eq(...))`. Looks like there is one now. I'm fine adding this here or in
another PR. A separate one would be cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
