szehon-ho commented on code in PR #7581:
URL: https://github.com/apache/iceberg/pull/7581#discussion_r1239123194
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -249,19 +273,31 @@ static class Partition {
private int posDeleteFileCount;
private long eqDeleteRecordCount;
private int eqDeleteFileCount;
+ private Long lastUpdatedMs;
+ private Long lastUpdatedSnapshotId;
Partition(StructLike key, Types.StructType keyType) {
this.partitionData = toPartitionData(key, keyType);
this.specId = 0;
- this.dataRecordCount = 0;
+ this.dataRecordCount = 0L;
this.dataFileCount = 0;
- this.posDeleteRecordCount = 0;
+ this.posDeleteRecordCount = 0L;
this.posDeleteFileCount = 0;
- this.eqDeleteRecordCount = 0;
+ this.eqDeleteRecordCount = 0L;
this.eqDeleteFileCount = 0;
+ this.lastUpdatedMs = null;
Review Comment:
Nit: is it necessary?
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -72,7 +72,17 @@ public class PartitionsTable extends BaseMetadataTable {
8,
"equality_delete_file_count",
Types.IntegerType.get(),
- "Count of equality delete files"));
+ "Count of equality delete files"),
+ Types.NestedField.optional(
+ 9,
+ "last_updated_ms",
+ Types.TimestampType.withZone(),
+ "Partition last updated timestamp"),
Review Comment:
Nit: Commit time of snapshot that last updated this partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
