jackye1995 commented on code in PR #6323:
URL: https://github.com/apache/iceberg/pull/6323#discussion_r1237721093
##########
python/pyiceberg/catalog/rest.py:
##########
@@ -489,6 +493,39 @@ def rename_table(self, from_identifier: Union[str,
Identifier], to_identifier: U
return self.load_table(to_identifier)
+ def _commit(self, *table_requests: CommitTableRequest) ->
CommitTableResponse:
Review Comment:
+1, given this is called afterwards in `Transaction`, it feels more nature
to call it just `commit_table` so we an use `self._table.catalog.commit_table`
instead of `self._table.catalog._commit`
##########
python/pyiceberg/table/__init__.py:
##########
@@ -64,25 +67,326 @@
import ray
from duckdb import DuckDBPyConnection
+ from pyiceberg.catalog import Catalog
ALWAYS_TRUE = AlwaysTrue()
+class Transaction:
Review Comment:
Do we plan to have another `MiltiTableTransaction` for transactions across
tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
