szehon-ho commented on code in PR #7352:
URL: https://github.com/apache/iceberg/pull/7352#discussion_r1231425205
##########
core/src/main/java/org/apache/iceberg/StaticDataTask.java:
##########
@@ -71,8 +71,10 @@ public List<DeleteFile> deletes() {
@Override
public CloseableIterable<StructLike> rows() {
- StructProjection projection = StructProjection.create(tableSchema,
projectedSchema);
- Iterable<StructLike> projectedRows =
Iterables.transform(Arrays.asList(rows), projection::wrap);
+ Iterable<StructLike> projectedRows =
Review Comment:
This isnt great as it will have a perf hit on the non Generic use case. Is
there a reason it works now in Spark engine?
I havent checked it, but it may be more an issue about ManifestReader using
Avro.read().reuseContainer() (ie, we need to make a defensive copy like in many
places in the code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
