cccs-eric commented on PR #7561: URL: https://github.com/apache/iceberg/pull/7561#issuecomment-1591804604
I tested this commit inside our fork to see if it would fix our idle connection timeout problem with Postgresql. Turns out the SQLState returned by Postgres (`57000`) is not part of the SQL standard. [Here](https://www.postgresql.org/docs/current/errcodes-appendix.html) is the list of possible error codes in Postgresql. I think the current PR is a step in the right direction, but limiting the support to a handful of standard SQL states will not address every use-case (read database vendor). Since the JDBCCatalog is written to work with any database supported by JDBC, we need to provide a configuration option to extend the list of SQLState related to retryable connection exceptions. The configurable list would be vendor specific since for example `57000` is a retryable exception for Postgresql, but maybe not for Oracle or MySQL. SQLStates are not vendor assigned, so they can be reused. @amogh-jahagirdar , do you think it would make sense to add a configurable option for a list of retryable connection exception codes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
