ConeyLiu commented on PR #7791: URL: https://github.com/apache/iceberg/pull/7791#issuecomment-1581980893
Thanks @Fokko for the review. > Did you confirm with the new WeakHashMap that the problem has been resolved? It needs to run several weeks or months to trigger the problem. I tested locally and the caching works as expected. > Do you think it is possible to add a check to see if the HashMap actually removes objects that are garbage collected? It would be nice to check its behavior now, but also we make sure that we keep this behavior in the future (it was broken in Avro along the way). Add the new UTs to cover this. Please take another look when you are free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
