nastra commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1219437247


##########
settings.gradle:
##########
@@ -192,3 +194,186 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
   }
 }
 
+dependencyResolutionManagement {

Review Comment:
   I would aim for putting most things into a version.toml file. Scala versions 
aren't updated too often, so I think in that case it's fine to define the scala 
version separately (in a gradle file)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to