flyrain commented on code in PR #7326:
URL: https://github.com/apache/iceberg/pull/7326#discussion_r1218691505
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/RemoveCarryoverIterator.java:
##########
@@ -151,13 +153,21 @@ private int[] generateIndicesToIdentifySameRow(int
columnSize) {
return indices;
}
- private boolean isSameRecord(Row currentRow, Row nextRow) {
- for (int idx : indicesToIdentifySameRow) {
+ protected boolean isSameRecord(Row currentRow, Row nextRow) {
+ for (int idx : indicesToIdentifySameRow()) {
Review Comment:
There are different `indicesToIdentifySameRow` for the two iterators. We
need to exclude the index of meta columns `CHANGE_ORDINAL` and
`COMMIT_SNAPSHOT_ID` in case of net changes. We cannot exclude them in case of
`RemoveCarryoverIterator`, since they serve as a boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
