nastra commented on code in PR #7719:
URL: https://github.com/apache/iceberg/pull/7719#discussion_r1214007801
##########
spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java:
##########
@@ -172,7 +172,11 @@ protected void assertEquals(String context, Object[]
expectedRow, Object[] actua
Object actualValue = actualRow[col];
if (expectedValue != null && expectedValue.getClass().isArray()) {
String newContext = String.format("%s (nested col %d)", context, col +
1);
- assertEquals(newContext, (Object[]) expectedValue, (Object[])
actualValue);
+ if (expectedValue instanceof byte[]) {
+ Assert.assertArrayEquals(newContext, (byte[]) expectedValue,
(byte[]) actualValue);
Review Comment:
`Assertions.assertThat(actualValue).as(newContext).isEqualTo(expectedValue)`
is usually the better option than `assertArrayEquals`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
