rdblue commented on code in PR #6323:
URL: https://github.com/apache/iceberg/pull/6323#discussion_r1209498177


##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -323,6 +323,17 @@ def rename_table(self, from_identifier: Union[str, 
Identifier], to_identifier: U
             NoSuchTableError: If a table with the name does not exist
         """
 
+    @abstractmethod
+    def update_table(self, identifier: Union[str, Identifier], updates: 
Tuple[TableUpdate, ...]) -> Table:

Review Comment:
   FYI, we're adding a similar method in @nastra's transaction work: 
https://github.com/apache/iceberg/pull/7569
   
   We probably want to align the naming so maybe this should be `commit_table` 
to align with the `commit_transaction`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to