rdblue commented on code in PR #7688:
URL: https://github.com/apache/iceberg/pull/7688#discussion_r1208658121
##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -187,7 +193,10 @@ public long targetSplitSize() {
long tableValue =
PropertyUtil.propertyAsLong(
table().properties(), TableProperties.SPLIT_SIZE,
TableProperties.SPLIT_SIZE_DEFAULT);
- return PropertyUtil.propertyAsLong(context.options(),
TableProperties.SPLIT_SIZE, tableValue);
+
+ long splitSize = adaptiveSplitSize(tableValue).orElse(tableValue);
Review Comment:
I don't quite understand. I thought most tables didn't have a split size
default explicitly set and would use the Iceberg default,
`TableProperties.SPLIT_SIZE_DEFAULT`. Is that not the case?
What I meant was that if the split size is explicitly set (not common, I
think) then we should always use it because it is static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
