szehon-ho commented on code in PR #7713:
URL: https://github.com/apache/iceberg/pull/7713#discussion_r1207215047
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -171,7 +171,10 @@ public Filter[] pushFilters(Filter[] filters) {
}
} catch (Exception e) {
- LOG.warn("Failed to check if {} can be pushed down: {}", filter,
e.getMessage());
Review Comment:
Yea I looked further, in the case that I was trying (a UDF column), it
doesn't even get into Iceberg. So we'd have to add the log in Spark side.
in Iceberg, the exception case that I add the log for here is just for
simple column which we dont support yet, like metadata column.
I guess we can add a log when it doesnt match the entire partition as well,
although not sure how to make correct phrasing, as iiuc we don't skip it but do
evaluate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
