Fokko commented on code in PR #6323:
URL: https://github.com/apache/iceberg/pull/6323#discussion_r1206036823
##########
python/pyiceberg/table/__init__.py:
##########
@@ -191,11 +445,14 @@ def from_metadata(cls, metadata_location: str,
properties: Properties = EMPTY_DI
metadata = FromInputFile.table_metadata(file)
+ from pyiceberg.catalog.null import NoopCatalog
+
return cls(
identifier=("static-table", metadata_location),
metadata_location=metadata_location,
metadata=metadata,
io=load_file_io({**properties, **metadata.properties}),
+ catalog=NoopCatalog("static-table"),
Review Comment:
I'd rather have the `NoopCatalog` because otherwise, we need to not-None
check everywhere we use the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
