linyanghao commented on code in PR #7628:
URL: https://github.com/apache/iceberg/pull/7628#discussion_r1201592463
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -472,11 +479,13 @@ public void alterTable(ObjectPath tablePath,
CatalogBaseTable newTable, boolean
CatalogTable table = toCatalogTable(icebergTable);
- // Currently, Flink SQL only support altering table properties.
+ // This alterTable API only supports altering table properties.
Review Comment:
It seems that flink is not deprecating the old alterTable API yet. This is
to support some legacy operations: `AlterTableSchemaOperation`,
`AlterViewPropertiesOperation` and `AlterViewAsOperation`.
Among these operations:
- `AlterTableSchemaOperation` is now [only used to alter hive
tables](https://github.com/apache/flink/blob/553c72a894b25c10e71e54e6567c187876234fd5/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java#L133).
- `AlterViewPropertiesOperation` and `AlterViewAsOperation` are for views.
So I guess it's safe to assume the old alterTable API won't be called by
flink when altering iceberg tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
