ajantha-bhat commented on code in PR #7676:
URL: https://github.com/apache/iceberg/pull/7676#discussion_r1201409911
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -331,24 +331,31 @@ private Result doExecuteWithPartialProgress(
RewriteDataFilesCommitManager commitManager) {
ExecutorService rewriteService = rewriteService();
- // Start Commit Service
+ // start commit service
int groupsPerCommit = IntMath.divide(ctx.totalGroupCount(), maxCommits,
RoundingMode.CEILING);
RewriteDataFilesCommitManager.CommitService commitService =
commitManager.service(groupsPerCommit);
commitService.start();
- // Start rewrite tasks
+ Collection<FileGroupFailureResult> rewriteFailures = new
ConcurrentLinkedQueue<>();
Review Comment:
you are right. It looks confusing to handle from this PR.
I have reverted it now. It can be done in another PR along with testcase and
procedure changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
