deniskuzZ commented on code in PR #6527:
URL: https://github.com/apache/iceberg/pull/6527#discussion_r1200567999
##########
core/src/main/java/org/apache/iceberg/util/ThreadPools.java:
##########
@@ -56,6 +64,18 @@ public static ExecutorService getWorkerPool() {
return WORKER_POOL;
}
+ /**
+ * Return an {@link ExecutorService} that uses "delete worker" thread-pool.
+ *
+ * <p>The size of this thread-pool is controlled by the Java system property
{@code
+ * iceberg.worker.delete-num-threads}.
+ *
+ * @return an {@link ExecutorService} that uses delete worker pool
+ */
+ public static ExecutorService getDeleteWorkerPool() {
Review Comment:
removed, however, https://github.com/apache/iceberg/pull/6432 looks
abandoned
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -46,4 +46,13 @@ public boolean isDeleted(long position) {
public boolean isEmpty() {
return roaring64Bitmap.isEmpty();
}
+
+ @Override
+ public PositionDeleteIndex or(PositionDeleteIndex deleteIndex) {
+ if (deleteIndex instanceof BitmapPositionDeleteIndex) {
+ roaring64Bitmap.or(((BitmapPositionDeleteIndex)
deleteIndex).roaring64Bitmap);
+ return this;
+ }
+ throw new IllegalArgumentException();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
