rdblue commented on code in PR #6775:
URL: https://github.com/apache/iceberg/pull/6775#discussion_r1199484333
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -498,6 +504,49 @@ def expression_to_pyarrow(expr: BooleanExpression) ->
pc.Expression:
return boolean_expression_visit(expr, _ConvertToArrowExpression())
+@lru_cache
+def _get_file_format(file_format: FileFormat, **kwargs: Dict[str, Any]) ->
ds.FileFormat:
+ if file_format == FileFormat.PARQUET:
+ return ds.ParquetFileFormat(**kwargs)
+ else:
+ raise ValueError(f"Unsupported file format: {file_format}")
+
+
+def _construct_fragment(fs: FileSystem, data_file: DataFile,
file_format_kwargs: Dict[str, Any] = EMPTY_DICT) -> ds.Fragment:
+ _, path = PyArrowFileIO.parse_location(data_file.file_path)
+ return _get_file_format(data_file.file_format,
**file_format_kwargs).make_fragment(path, fs)
+
+
+def _read_deletes(fs: FileSystem, data_file: DataFile) -> Dict[str,
pa.ChunkedArray]:
+ delete_fragment = _construct_fragment(
+ fs, data_file, file_format_kwargs={"dictionary_columns":
("file_path",), "pre_buffer": True, "buffer_size": ONE_MEGABYTE}
+ )
+ table = ds.Scanner.from_fragment(fragment=delete_fragment).to_table()
+ table = table.unify_dictionaries()
+ return {
+ file.as_py(): table.filter(pc.field("file_path") == file).column("pos")
+ for file in table.column("file_path").chunks[0].dictionary
+ }
+
+
+def _create_positional_deletes_indices(positional_deletes:
List[pa.ChunkedArray], fn_rows: Callable[[], int]) -> pa.Array:
+ sorted_deleted = merge(*positional_deletes)
+
+ def generator() -> Generator[int, None, None]:
+ deleted_pos = next(sorted_deleted).as_py() # type: ignore
+ for pos in range(fn_rows()):
+ if deleted_pos == pos:
+ try:
+ deleted_pos = next(sorted_deleted).as_py() # type: ignore
Review Comment:
A position can be deleted more than once in some concurrent cases, so this
needs to keep calling `next` until it is not equal to `pos`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
