rdblue commented on code in PR #7553:
URL: https://github.com/apache/iceberg/pull/7553#discussion_r1198350855
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -63,6 +63,21 @@ public SparkReadConf(
this.branch = branch;
this.readOptions = readOptions;
this.confParser = new SparkConfParser(spark, table, readOptions);
+
+ // We only want to check the session conf and the read options, since the
table can
+ // also be read with other version of r
+ if
(spark.conf().contains(SparkSQLProperties.HANDLE_TIMESTAMP_WITHOUT_TIMEZONE)) {
+ throw new UnsupportedOperationException(
+ "Spark configuration "
+ + SparkSQLProperties.HANDLE_TIMESTAMP_WITHOUT_TIMEZONE
+ + " is not supported in Spark 3.4 due to the introduction of
native support for timestamp without timezone.");
+ }
+ if
(readOptions.containsKey(SparkReadOptions.HANDLE_TIMESTAMP_WITHOUT_TIMEZONE)) {
Review Comment:
Nit: spacing after the last block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
