szehon-ho commented on PR #7558:
URL: https://github.com/apache/iceberg/pull/7558#issuecomment-1550486478
Just a note for later pr : the new benchmark makes a ErrorProne warning:
```
> Task :iceberg-spark:iceberg-spark-extensions-3.4_2.12:compileJmhJava
/Users/szehon/repos/apache-iceberg/iceberg/spark/v3.4/spark-extensions/src/jmh/java/org/apache/iceberg/spark/MergeCardinalityCheckBenchmark.java:224:
warning: [AnnotateFormatMethod] This method passes a pair of parameters
through to String.format, but the enclosing method wasn't annotated
@FormatMethod. Doing so gives compile-time rather than run-time protection
against malformed format strings.
private void sql(String query, Object... args) {
^
(see https://errorprone.info/bugpattern/AnnotateFormatMethod)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
