singhpk234 commented on issue #7623: URL: https://github.com/apache/iceberg/issues/7623#issuecomment-1550084392
can confirm disabling `aggregate-push-down-enabled` makes this test pass interesting thing is was agg push down suppose to work with incremental scan as we are not building incremental scan, rather than just a simple scan, https://github.com/apache/iceberg/blob/9907a97351138e676d08e02ea53b746f4e331ec6/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java#L224-L230 As per my understanding, The readSnapshot function just checks if there is a snapshot passed or use the latest snapshot, should we disable the Agg push down for now when we detect it's an incremental scan for now for 1.3.0 and add support for incremental scan as follow-up. Thoughts @RussellSpitzer @huaxingao ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
