singhpk234 commented on code in PR #7531:
URL: https://github.com/apache/iceberg/pull/7531#discussion_r1190450359
##########
build.gradle:
##########
@@ -729,6 +730,7 @@ project(':iceberg-parquet') {
api project(':iceberg-api')
implementation project(':iceberg-core')
implementation project(':iceberg-common')
+ implementation 'com.github.rdblue:brotli-codec:0.1.1'
Review Comment:
we require this dependency in runtime, hence added it as implementation, we
load the the Codec class dynamically via -
```
Class<?> codecClass;
try {
codecClass = Class.forName(codecClassName);
} catch (ClassNotFoundException e) {
// Try to load the class using the job classloader
codecClass =
configuration.getClassLoader().loadClass(codecClassName);
}
```
Hence just having compileOnly dependency might not work (made the change to
make this compileOnly, it still fails), are you recommending we should not
include Brotli codec jar and update the iceberg doc instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
