aokolnychyi commented on code in PR #7558:
URL: https://github.com/apache/iceberg/pull/7558#discussion_r1187803191
##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteMergeIntoTable.scala:
##########
@@ -257,8 +259,17 @@ object RewriteMergeIntoTable extends
RewriteRowLevelIcebergCommand with Predicat
val (targetCond, joinCond) = splitMergeCond(cond, readRelation)
+ val performCardinalityCheck = isCardinalityCheckNeeded(matchedActions)
+
// project an extra column to check if a target row exists after the join
- val targetTableProjExprs = readAttrs :+ Alias(TrueLiteral,
ROW_FROM_TARGET)()
+ // if needed, project a synthetic row ID to perform the cardinality check
+ val rowFromTarget = Alias(TrueLiteral, ROW_FROM_TARGET)()
Review Comment:
I initially added a method for this logic but it made the main method harder
to read by hiding the actual projection expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
