rdblue commented on code in PR #7412:
URL: https://github.com/apache/iceberg/pull/7412#discussion_r1186927453
##########
spark/v3.1/build.gradle:
##########
@@ -216,6 +216,7 @@ project(':iceberg-spark:iceberg-spark-runtime-3.1_2.12') {
implementation (project(':iceberg-snowflake')) {
exclude group: 'net.snowflake' , module: 'snowflake-jdbc'
}
+ implementation project(':iceberg-gcp')
Review Comment:
I'd remove this. We can iterate much more quickly if we get this code into
Iceberg. This addition causes us to need to validate the size of the
iceberg-gcp module as well as the transitive dependencies it pulls in. That
will block this PR until we do the analysis. I think we should focus on getting
the logic of the catalog right, and then add it for distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
