danielcweeks commented on code in PR #6952:
URL: https://github.com/apache/iceberg/pull/6952#discussion_r1186415027
##########
snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java:
##########
@@ -343,4 +366,32 @@ public SnowflakeTableMetadata
loadTableMetadata(SnowflakeIdentifier tableIdentif
public void close() {
connectionPool.close();
}
+
+ private Optional<RuntimeException> snowflakeExceptionToIcebergException(
Review Comment:
I think you could avoid the optional with all the additional `orElseGet`
statements above by just passing in the generic text and falling back to an
UncheckedSQLException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
