JonasJ-ap commented on code in PR #7523: URL: https://github.com/apache/iceberg/pull/7523#discussion_r1185038580
########## python/pyiceberg/io/pyarrow.py: ########## @@ -612,14 +612,40 @@ def _get_field_doc(field: pa.Field) -> Optional[str]: class _ConvertToIceberg(PyArrowSchemaVisitor[Union[IcebergType, Schema]]): + def __init__(self, expected_schema: Optional[Schema] = None): + self.expected_schema = expected_schema + + def cast_if_needed(self, field_id: int, field_type: IcebergType) -> IcebergType: Review Comment: Thank you so much for the explanation and test. I've changed the PR to add the promotion from FixedType[16] to UUIDType instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
