nastra commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1183945601
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -485,8 +505,13 @@ private ScheduledExecutorService tokenRefreshExecutor() {
public void close() throws IOException {
shutdownRefreshExecutor();
- if (client != null) {
- client.close();
+ if (closeableGroup != null) {
+ closeableGroup.close();
+ }
+
+ if (fileIOCloser != null) {
+ fileIOCloser.cleanUp();
+ fileIOCloser.invalidateAll();
Review Comment:
I would have thought that it's more appropriate to perform any pending
maintenance operations first (so that underlying `FileIO` instances are being
closed) before clearing the entire cache through invalidation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
