rdblue commented on code in PR #7496:
URL: https://github.com/apache/iceberg/pull/7496#discussion_r1183859414
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcValueWriters.java:
##########
@@ -85,6 +85,9 @@ private static class UUIDWriter implements
OrcValueWriter<UTF8String> {
@Override
public void nonNullWrite(int rowId, UTF8String data, ColumnVector output) {
+ // ((BytesColumnVector) output).setRef(..) just stores a reference to
the passed byte[], so
+ // can't use a ThreadLocal ByteBuffer here like in other places because
subsequent writes
+ // would then overwrite previous values
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
