theoxu31 commented on code in PR #6742:
URL: https://github.com/apache/iceberg/pull/6742#discussion_r1183166454
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -269,14 +269,6 @@ public void testRenameTableFailsToDeleteOldTable() {
.databaseName(namespace)
.tableInput(TableInput.builder().name(tableName).parameters(Maps.newHashMap()).build())
.build());
- AssertHelpers.assertThrows(
- "should fail to rename",
- ValidationException.class,
- "Input Glue table is not an iceberg table",
- () ->
- glueCatalog.renameTable(
- TableIdentifier.of(namespace, tableName),
- TableIdentifier.of(namespace, newTableName)));
Review Comment:
This assertion was removed due to the logic change in renameTable that
allows rename table to use the previous table's Iceberg Properties (metadata
location) the related integration test would always fail at this assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
