nastra commented on code in PR #7468:
URL: https://github.com/apache/iceberg/pull/7468#discussion_r1182245984
##########
api/src/test/java/org/apache/iceberg/types/TestTypeUtil.java:
##########
@@ -450,20 +449,14 @@ public void testProjectListNested() {
required(17, "x", Types.IntegerType.get()),
required(18, "y",
Types.IntegerType.get()))))))));
- AssertHelpers.assertThrows(
- "Cannot explicitly project List",
- IllegalArgumentException.class,
- () -> TypeUtil.project(schema, Sets.newHashSet(12)));
+ Assertions.assertThatThrownBy(() -> TypeUtil.project(schema,
Sets.newHashSet(12)))
+ .isInstanceOf(IllegalArgumentException.class);
Review Comment:
these should all check for a specific error msg, as otherwise the called
code could fail for a different reason than the one being expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
