wypoon commented on code in PR #7469:
URL: https://github.com/apache/iceberg/pull/7469#discussion_r1181958644
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -41,6 +41,11 @@ private CatalogProperties() {}
public static final boolean CACHE_ENABLED_DEFAULT = true;
+ /** Controls whether the caching catalog will cache table entries using
case-sensitive keys. */
+ public static final String CACHE_CASE_SENSITIVE = "cache.case-sensitive";
+
+ public static final boolean CACHE_CASE_SENSITIVE_DEFAULT = false;
Review Comment:
Yes, and that is the problem. I'd argue that we should default the case
sensitivity to false, because I think this causes the least surprise to users.
If others have use cases where they need case sensitivity to be true, I'd
like to hear about them. I may yet be convinced that case sensitivity should
default to true.
In any case, this critical point is that now the case sensitivity can be
configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
