nastra commented on code in PR #7444: URL: https://github.com/apache/iceberg/pull/7444#discussion_r1180417442
########## aws/src/main/java/org/apache/iceberg/aws/metrics/SqsMetricsReporter.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.aws.metrics; + +import java.util.Map; +import org.apache.iceberg.metrics.CommitReport; +import org.apache.iceberg.metrics.CommitReportParser; +import org.apache.iceberg.metrics.MetricsReport; +import org.apache.iceberg.metrics.MetricsReporter; +import org.apache.iceberg.metrics.ScanReport; +import org.apache.iceberg.metrics.ScanReportParser; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import software.amazon.awssdk.services.sqs.SqsClient; +import software.amazon.awssdk.services.sqs.model.SendMessageRequest; + +/** An implementation of {@link MetricsReporter} which reports {@link MetricsReport} to SQS */ +public class SqsMetricsReporter implements MetricsReporter { + + private static final Logger LOG = LoggerFactory.getLogger(SqsMetricsReporter.class); + + private SqsClient sqsClient; + + private String sqsQueueUrl; + + @Override + public void initialize(Map<String, String> properties) { + SqsMetricsReporterProperties sqsMetricsReporterProperties = + new SqsMetricsReporterProperties(properties); + SqsClientFactory sqsClientFactory = new SqsClientFactory(sqsMetricsReporterProperties); + sqsClient = sqsClientFactory.sqs(); + sqsQueueUrl = sqsMetricsReporterProperties.sqsQueueUrl(); + Preconditions.checkArgument( Review Comment: should this rather be checked in `SqsMetricsReporterProperties`? ########## aws/src/main/java/org/apache/iceberg/aws/metrics/SqsMetricsReporter.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.aws.metrics; + +import java.util.Map; +import org.apache.iceberg.metrics.CommitReport; +import org.apache.iceberg.metrics.CommitReportParser; +import org.apache.iceberg.metrics.MetricsReport; +import org.apache.iceberg.metrics.MetricsReporter; +import org.apache.iceberg.metrics.ScanReport; +import org.apache.iceberg.metrics.ScanReportParser; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import software.amazon.awssdk.services.sqs.SqsClient; +import software.amazon.awssdk.services.sqs.model.SendMessageRequest; + +/** An implementation of {@link MetricsReporter} which reports {@link MetricsReport} to SQS */ +public class SqsMetricsReporter implements MetricsReporter { + + private static final Logger LOG = LoggerFactory.getLogger(SqsMetricsReporter.class); + + private SqsClient sqsClient; + + private String sqsQueueUrl; + + @Override + public void initialize(Map<String, String> properties) { + SqsMetricsReporterProperties sqsMetricsReporterProperties = + new SqsMetricsReporterProperties(properties); + SqsClientFactory sqsClientFactory = new SqsClientFactory(sqsMetricsReporterProperties); + sqsClient = sqsClientFactory.sqs(); + sqsQueueUrl = sqsMetricsReporterProperties.sqsQueueUrl(); + Preconditions.checkArgument( + null != sqsQueueUrl, "%s should be be set", SqsMetricsReporterProperties.SQS_QUEUE_URL); + } + + @Override + public void report(MetricsReport report) { + if (null == report) { + LOG.warn("Received invalid metrics report: null"); + return; + } + + try { + String message = null; + if (report instanceof CommitReport) { + message = CommitReportParser.toJson((CommitReport) report); + } else if (report instanceof ScanReport) { + message = ScanReportParser.toJson((ScanReport) report); + } + + if (null == message) { + LOG.warn("Received unknown MetricsReport type"); + return; + } + + LOG.info("Received metrics report: {}", message); + sqsClient.sendMessage( + SendMessageRequest.builder().messageBody(message).queueUrl(sqsQueueUrl).build()); + } catch (Exception e) { + LOG.warn("Failed to report metrics to SQS queue {}", sqsQueueUrl, e); + } finally { + sqsClient.close(); Review Comment: do we want to close the sqs client after every metrics report? Typically we would want to re-use a client I would have assumed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
