RussellSpitzer commented on code in PR #7443: URL: https://github.com/apache/iceberg/pull/7443#discussion_r1179577826
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkFunctionCatalog.java: ########## @@ -16,23 +16,30 @@ * specific language governing permissions and limitations * under the License. */ +package org.apache.iceberg.spark; Review Comment: I wonder a little about the naming here, I know i'm always confused about SparkCatalog (our class) versus the Spark Catalog class. IcebergFunctionCatalog? I don't feel strongly about this though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
