Fokko commented on code in PR #7436:
URL: https://github.com/apache/iceberg/pull/7436#discussion_r1177631282
##########
python/tests/utils/test_bin_packing.py:
##########
@@ -41,7 +41,7 @@ def weight_func(x: int) -> int:
return max(x, open_cost)
item_list_sums: List[int] = [sum(item) for item in PackingIterator(splits,
split_size, lookback, weight_func)]
- assert all([split_size >= item_sum >= 0 for item_sum in item_list_sums])
+ assert all(split_size >= item_sum >= 0 for item_sum in item_list_sums)
Review Comment:
This is a very nice check because it will exit the loop when one `false` has
been encountered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
