[GitHub] [iceberg] nastra commented on a diff in pull request #7370: Core: Make metrics reporter serializable

[via GitHub]

nastra commented on code in PR #7370:
URL: https://github.com/apache/iceberg/pull/7370#discussion_r1177490045


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -121,6 +122,9 @@ private FileIO io(String location) {
     String impl = implFromLocation(location);
     FileIO io = ioInstances.get(impl);
     if (io != null) {
+      if (io instanceof HadoopFileIO && ((HadoopFileIO) io).conf() == null) {

Review Comment:
   Sorry, forgot to mention why I added this. It appears that the underlying 
`conf` of `HadoopFileIO` wasn't initialized when calling 
`StaticTableOperations.current()`:
   
   
![hadoop_io_conf_missing](https://user-images.githubusercontent.com/271029/234508649-e0499213-3992-4474-9b93-838314586839.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org