munendrasn commented on code in PR #6862:
URL: https://github.com/apache/iceberg/pull/6862#discussion_r1176864705
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -300,6 +300,12 @@ public class AwsProperties implements Serializable {
public static final String DYNAMODB_TABLE_NAME_DEFAULT = "iceberg";
+ public static final String DYNAMODB_V2_SCHEMA_DEFAULT_TABLE_NAME =
"iceberg_dynamodb_v2";
+
+ public static final String DYNAMODB_CATALOG_SCHEMA_VERSION =
"dynamodb.catalog.schema-version";
+
+ public static final int DYNAMODB_DEFAULT_SCHEMA_VERSION = 1;
Review Comment:
AFAIK, Until now, some of the bugs encountered in DynamoDbCatalog might not
surface to user depending on how users might be using the Catalog
* listTables is uncommon operation, and only at higher cardinality the bug
would
[surface](https://github.com/apache/iceberg/commit/e1a09e78efd41bc8dbb095879254a89213b80464)
* default warehouse bug too might not surface if user always provides
explicit location to table or warehouse path is not set in the namespace
Probably, there might be users with dependencies on DynamoDbCatalog. So, we
would need to consider the impact for those users.
Still, it might be okay to make v2 as default if we call this change out in
the release as major change - just a cautionary note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
