rdblue commented on code in PR #7417:
URL: https://github.com/apache/iceberg/pull/7417#discussion_r1175866531
##########
core/src/main/java/org/apache/iceberg/view/SQLViewRepresentationParser.java:
##########
@@ -35,7 +35,7 @@ class SQLViewRepresentationParser {
private static final String DEFAULT_CATALOG = "default-catalog";
private static final String DEFAULT_NAMESPACE = "default-namespace";
private static final String FIELD_ALIASES = "field-aliases";
- private static final String FIELD_COMMENTS = "field-comments";
+ private static final String FIELD_DOCS = "field-docs";
Review Comment:
I updated to comments. I think we can still make a few changes like this
where needed and I agree that comments works better.
The original logic was to be like "doc" in the schema fields, but that's
already there and this is a separate concept that has multiple fields. I don't
think we're losing much by making it more similar to the SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
