aokolnychyi commented on code in PR #7424:
URL: https://github.com/apache/iceberg/pull/7424#discussion_r1175825193
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestStoragePartitionedJoinsInRowLevelOperations.java:
##########
@@ -257,14 +261,22 @@ private void checkMerge(RowLevelOperationMode mode) {
SparkPlan plan =
executeAndKeepPlan(
"MERGE INTO %s AS t USING %s AS s "
- + "ON t.id = s.id AND t.dep = s.dep AND t.dep = 'hr'"
Review Comment:
This condition was a hard requirement in 3.3, otherwise SPJ would not kick
in. It is no longer needed, so I adapted the test to verify mismatching keys
are supported. That's the usual MERGE use case since it may contain data for
new partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
