nastra commented on code in PR #7337: URL: https://github.com/apache/iceberg/pull/7337#discussion_r1170856579
########## core/src/main/java/org/apache/iceberg/metrics/CompositeMetricsReporter.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.metrics; + +import java.util.List; +import java.util.Map; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.SerializableMap; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A composite {@link MetricsReporter} that allows registering multiple {@link MetricsReporter} + * instances. All registered {@link MetricsReporter} will be notified once a new {@link + * MetricsReport} is available. + */ +public class CompositeMetricsReporter implements MetricsReporter { + private static final Logger LOG = LoggerFactory.getLogger(CompositeMetricsReporter.class); + private final Map<Class<?>, MetricsReporter> metricsReporters; + + public CompositeMetricsReporter() { + metricsReporters = SerializableMap.copyOf(Maps.newConcurrentMap()); + } + + public CompositeMetricsReporter register(MetricsReporter reporter) { + Preconditions.checkArgument(null != reporter, "Invalid metrics reporter: null"); + + if (reporter instanceof CompositeMetricsReporter) { + ((CompositeMetricsReporter) reporter) + .metricsReporters() + .forEach(r -> metricsReporters.putIfAbsent(r.getClass(), r)); + } else { + metricsReporters.putIfAbsent(reporter.getClass(), reporter); + } + + return this; + } + + @Override + public void report(MetricsReport report) { + Preconditions.checkArgument(null != report, "Invalid metrics report: null"); + + metricsReporters + .values() + .forEach( + reporter -> { + try { + reporter.report(report); + } catch (Exception e) { Review Comment: the reason I'm catching an `Exception` here is that I think we generally don't want to interfere with actual scans or commits when anything on the reporting side fails. Generally speaking, every reporter should make sure that it doesn't interefere with the scan/commit path when reporting and something fails but I'm not sure we can enforce that. I'm a bit worried that if we only catch `RuntimeException` and some reporter misbehaves in an unexpected way, we'd have to go back and fix either the misbehaving reporter or this catch clause. thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
