Fokko commented on code in PR #7109:
URL: https://github.com/apache/iceberg/pull/7109#discussion_r1169854299
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileScanTaskReader.java:
##########
@@ -54,13 +58,27 @@ public class RowDataFileScanTaskReader implements
FileScanTaskReader<RowData> {
private final Schema projectedSchema;
private final String nameMapping;
private final boolean caseSensitive;
+ private final FlinkSourceFilter rowFilter;
public RowDataFileScanTaskReader(
- Schema tableSchema, Schema projectedSchema, String nameMapping, boolean
caseSensitive) {
+ Schema tableSchema,
+ Schema projectedSchema,
+ String nameMapping,
+ boolean caseSensitive,
+ List<Expression> filters) {
this.tableSchema = tableSchema;
this.projectedSchema = projectedSchema;
this.nameMapping = nameMapping;
this.caseSensitive = caseSensitive;
+
+ if (filters != null && !filters.isEmpty()) {
+ Expression combinedExpression =
+ filters.stream().reduce(Expressions.alwaysTrue(), Expressions::and);
Review Comment:
I fully agree. Good to pick this up in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
