szehon-ho commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1169501029
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -90,54 +118,60 @@ private DataTask task(StaticTableScan scan) {
private static StaticDataTask.Row convertPartition(Partition partition) {
return StaticDataTask.Row.of(
- partition.key, partition.specId, partition.dataRecordCount,
partition.dataFileCount);
+ partition.key,
+ partition.specId,
+ partition.dataRecordCount,
+ partition.dataFileCount,
+ partition.posDeleteRecordCount,
+ partition.posDeleteFileCount,
+ partition.eqDeleteRecordCount,
+ partition.eqDeleteFileCount);
}
private static Iterable<Partition> partitions(Table table, StaticTableScan
scan) {
Types.StructType normalizedPartitionType =
Partitioning.partitionType(table);
PartitionMap partitions = new PartitionMap();
- // cache a position map needed by each partition spec to normalize
partitions to final schema
- Map<Integer, int[]> normalizedPositionsBySpec =
- Maps.newHashMapWithExpectedSize(table.specs().size());
+ try (CloseableIterable<DataFile> datafiles = planDataFiles(scan);
Review Comment:
I would say, to try this if we can, both to clean the code and also as we
don't do another scan.
I think it may work by doing 'CloseableIterables.transform()' in the worst
case to cast the type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
