chenjunjiedada commented on code in PR #7338:
URL: https://github.com/apache/iceberg/pull/7338#discussion_r1166735951
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##########
@@ -136,12 +137,21 @@ static CloseableIterable<CombinedScanTask> planTasks(
}
}
- private enum ScanMode {
+ @VisibleForTesting
+ enum ScanMode {
BATCH,
INCREMENTAL_APPEND_SCAN
}
- private static ScanMode checkScanMode(ScanContext context) {
+ @VisibleForTesting
+ static ScanMode checkScanMode(ScanContext context) {
Review Comment:
>For the conditions here, is there any other simpler logic? E.g., is it
enough to just remove the context.isStreaming() condition in the original if
clause?
Yes, it looks more simple and more direct.
> Also I think it is better safer/more clear to construct a new ScanContext
object and set the useSnapshotId.
Agree, we can use `scanContext.copyWithSnapshotId` to achieve that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
