reswqa commented on issue #7160: URL: https://github.com/apache/iceberg/issues/7160#issuecomment-1507850136
Thanks @jackye1995 for the quick reply! > Regarding Junit5 vs AssertJ Assertions, what did Flink community do? Earlier, many different types of assertions were mixed in Flink's codebase, such as `Junit4` assertion, `Hamcrest`,`some custom assertion`, etc. While migrating to `Junit5`, Flink community decided that use `AssertJ` as the only assertion framework. > Do you think using AssertJ Assertions (which seems to be the consensus above) is preferred over Junit5? In my personal experience, `AssertJ` is really powerful and the benefit speaks for itself. - Thanks to its chained assertion style, we can avoid writing a lot of redundant code. - It has truly helpful error messages. - It provides a dedicated assertion API for many types, which will greatly reduce the burden of writing tests and increase the readability of the code. - Provides assertions for Guava types like Multimap, Table, Optional or ByteSource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
