gustavoatt commented on code in PR #7120:
URL: https://github.com/apache/iceberg/pull/7120#discussion_r1165837298
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -115,6 +121,20 @@ public String wapId() {
return sessionConf.get("spark.wap.id", null);
}
+ public int outputSpecId() {
+ final int outputSpecId =
Review Comment:
Done. I usually just keep the final as a way of having something like
`const` to avoid accidentally modifying something I did not intend to. But I
think it is not necessary in this case and would prefer to do it to keep
consistency in the rpo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
